Karma chameleon #1187

gkatsev · 2014-05-01T22:17:20Z

This enabled karma testing by default.
Also, it enabled karma testing via saucelabs on travis if the test is initiated by a branch from the main repository, otherwise, it runs the tests in phantomjs using karma. This is because travis ci doesn't export secure credentials on PRs created outside of the main repo.

This is the initial pass of the karma configurations. It should be good to go but it's a bit verbose. I'll be looking into how we can avoid the configuration duplication.

Some platforms produce frequent mousemove events whether or not the mouse has moved. This causes the UI to always be displayed since userActive_ is always `true`. By keeping track of the last mouse position and only firing if the new position is different, we can eleminate the event spam.

Conflicts: dist/video-js/video-js.css dist/video-js/video-js.min.css dist/video-js/video.js

Squashed commit of the following: commit 2c5d4d5 Author: Tom Johnson <[email protected]> Date: Tue Apr 1 15:02:37 2014 -0700 update control text for liveDisplay component commit 10f21cc Author: Tom Johnson <[email protected]> Date: Tue Apr 1 12:23:20 2014 -0700 whitespace fix commit 6a093d6 Author: Tom Johnson <[email protected]> Date: Tue Apr 1 12:21:42 2014 -0700 remove window scope of infinity commit 2dd8284 Author: Tom Johnson <[email protected]> Date: Tue Apr 1 12:12:13 2014 -0700 update to fix infinity capitalization. only do css logic on valid duration. set any duration of less than zero to window.Infinity commit f940bef Author: Tom Johnson <[email protected]> Date: Tue Apr 1 10:01:27 2014 -0700 update to less than zero on player durationChange commit 554c003 Author: Tom Johnson <[email protected]> Date: Mon Mar 31 17:26:13 2014 -0700 update exports, fix tests commit 2fb10cb Author: Tom Johnson <[email protected]> Date: Mon Mar 31 13:39:00 2014 -0700 fix tests, remove update display list in LiveDisplay commit bc47c5e Author: Tom Johnson <[email protected]> Date: Mon Mar 31 13:13:43 2014 -0700 Basic UI for Live

Included are two sanity check tests for the two areas being checked to make sure that the menu title items are being correctly placed in the actual UL element of the menu. Fixes videojs#1107

Squashed commit of the following: commit d5957da Author: David LaPalomento <[email protected]> Date: Mon Mar 31 16:22:43 2014 -0400 Peg the volume control to 1.0 on init Setup styles so that the volume control initially renders at full volume. This matches browser behavior where volume is available and saves Javascript from having to manually update the volume control on init. After the initial draw, the volume control is updated dynamically the same way it was before. commit 8bc861f Author: David LaPalomento <[email protected]> Date: Wed Mar 12 17:16:30 2014 -0400 Don't force sliders to get evaluated on load Since the load and play progress sliders are guaranteed to start from zero, set that through CSS. Calling Slider.prototype.update forces a re-flow because element dimensions are queried and style rules changed. That reflow consistently took around 60ms on my laptop which would mean dropped frames and "jerkiness" on initialization.

…clarity

…deo.js into coursera-feature/fix-menu-title

small typo fix in code that leads to error

getElementsById -> getElementById

Conflicts: dist/video-js/video-js.css dist/video-js/video-js.min.css dist/video-js/video.js

Added information on MIME type server configuration to self-hosting instructions in setup.md

… into coursera-feature/fix-menu-title

…e events

…ideojs#1002

…oad13-mousespam

…ff-feature/tech-error

…to heff-feature/tech-error

…ations on the variables must be enclosed in parentheses so the compiler takes as math operations and not as strings.

…owsers that also have JavaScript disabled

Added line to the changelog for PR merge.

Squashed commit of the following: commit 81d7859 Author: Steve Heffernan <[email protected]> Date: Mon May 12 12:53:59 2014 -0700 Removed unneeded comments commit c7ad732 Author: Steve Heffernan <[email protected]> Date: Fri May 9 14:29:31 2014 -0700 Addressed comments in videojs#1191 Now clearing errors on loadstart events. Added some default error messages. commit a742239 Author: Steve Heffernan <[email protected]> Date: Wed May 7 15:38:31 2014 -0700 Fixed the error display to hide by default commit 561c3f8 Author: Steve Heffernan <[email protected]> Date: Mon May 5 10:44:47 2014 -0700 Added support for displaying a message for the error. commit 2214207 Author: Steve Heffernan <[email protected]> Date: Fri May 2 17:18:22 2014 -0700 Updated spinner to hide on all errors commit 95d7e70 Author: Steve Heffernan <[email protected]> Date: Fri May 2 15:37:44 2014 -0700 Exported ErrorDisplay commit 11ca9cd Author: Steve Heffernan <[email protected]> Date: Fri May 2 15:35:46 2014 -0700 Updated flash tech to support new errors commit 56cbe66 Author: Steve Heffernan <[email protected]> Date: Fri May 2 13:06:49 2014 -0700 Started on better error handling and displaying in the UI when an error has occurred. commit 740014c Author: Steve Heffernan <[email protected]> Date: Wed Apr 30 16:11:33 2014 -0700 Added better global log/error/warn functions. Added sinon.js for stubs in tests. Updated grunt version to satisfy peer dependency warning.

gkatsev · 2014-05-14T03:31:21Z

I updated to allow running the tests in more browsers via the test task. I also consolidated the karma.conf and the localkarma.conf.

gkatsev · 2014-05-14T03:51:42Z

So, for watch, the config has which task to run. We could set it to karma:dev which runs karma in firefox, chrome, and safari or just set it to chrome.
However, karma has some built-in watch capabilities that is separate from what grunt-watch provides.
Probably the correct solution is investigate karma's watch and use that (in addition?) to grunt-watch, but for now we should change the task that grunt-watch runs to something like test.

gkatsev · 2014-05-14T03:53:59Z

Also, I tested that the "travis pr" thing works, still via

TRAVIS_PULL_REQUEST=true grunt test

…HTML5 tech triggers it. fixes videojs#1208 fixes videojs#1207 fixes videojs#1193

- use triple equals - don't block play call on error

heff · 2014-05-14T23:58:32Z

test/karma.conf.js

+
+    files: [
+      '../test/karma-qunit-shim.js',
+      "../src/js/core.js",


If we can find a way to not duplicate the source file list here that'd be good.

Actually, yes, we can collapse this down to a glob.

Unfortunately, it seems like we may not be able to collapse this into a glob because then the files won't load in the right order.

…atsev-karma-chameleon Conflicts: package.json

heff · 2014-05-15T00:04:44Z

Gruntfile.js

+        tasksMinified,
+        tasksMinifiedApi;
+
+    grunt.task.run(['jshint', 'less', 'build', 'minify', 'usebanner']);


I've had issues with assuming grunt.task.run would happen synchronously inside a function like this. It seems to be working fine here, but just a warning.

grunt.task.run queues up the list of tasks to be ran after this function exits. So, basically, this function queues up

jshint

less

build

minify

usebanner

karma:chrome

karma:minified_chrome

karma:minfied_api_chrome

to be run.

Oh interesting. Sorry, I didn't look deep enough to realize you were manipulating the tasks array with this.

And now I understand my previous issues with grunt.task.run... :-P. I was assuming the tasks would be run inline.

Gkatsev karma chameleon

heff · 2014-05-16T20:55:04Z

Gruntfile.js

+      chromecanary: {
+        browsers: ['ChromeCanary']
+      },
+      chrome: {


What does having these individual browser definitions get us?

download13 and others added 30 commits March 9, 2014 13:39

Array traversing for children opts - closes videojs#1070

204bb84

Fixed some formatting issues & added .each doc

799f176

Replaced webkitRequestFullScreen with webkitReplaceFullscreen

61eb54a

Removed dist files

aeb4aa3

Merge branch 'stable'

06e141d

Conflicts: dist/video-js/video-js.css dist/video-js/video-js.min.css dist/video-js/video.js

Removed dist files

efe25c0

Added line to the changelog

d784f9d

Making sure that the title element gets placed into the UL element

c7e35e5

Included are two sanity check tests for the two areas being checked to make sure that the menu title items are being correctly placed in the actual UL element of the menu. Fixes videojs#1107

Reset player on source change. closes videojs#1050 closes videojs#1124

95c29e6

Updated volume slider to use ems intead of percent for default value …

4e0c2b3

…clarity

Merge branch 'feature/fix-menu-title' of git://github.com/coursera/vi…

35d7258

…deo.js into coursera-feature/fix-menu-title

Adjusting menu to use title given in options

9d25874

getElementsById -> getElementById

d8f721a

small typo fix in code that leads to error

Merge pull request videojs#1130 from stin7/patch-1

2fca844

getElementsById -> getElementById

Merge branch 'stable'

2473d5b

Conflicts: dist/video-js/video-js.css dist/video-js/video-js.min.css dist/video-js/video.js

Merge branch 'master' of github.com:videojs/video.js

3bafdee

Included self-hosting MIME type instructions

31918fc

Added information on MIME type server configuration to self-hosting instructions in setup.md

Merge branch 'feature/fix-menu-title' of github.com:coursera/video.js…

4660573

… into coursera-feature/fix-menu-title

Update setup.md

c1029ea

Included self-hosting MIME type instructions

e8722ff

Making sure a tech exists when starting manual progress and timeupdat…

65833f5

…e events

Trigger one last timepudate when stopping manual timeupdates. fixes v…

f98012a

…ideojs#1002

Merge branch 'mousespam' of github.com:download13/video.js into downl…

8c9a4cc

…oad13-mousespam

Merge branch 'feature/tech-error' of github.com:heff/video-js into he…

f4704ee

…ff-feature/tech-error

Merge branch 'feature/fix-timeupdates' of github.com:heff/video-js in…

16eea0a

…to heff-feature/tech-error

Fixed compilation failure with LESS v1.7.0 and GRUNT v0.4.4. The oper…

923ce03

…ations on the variables must be enclosed in parentheses so the compiler takes as math operations and not as strings.

Added a more informative and styled fallback message for non-html5 br…

227700a

…owsers that also have JavaScript disabled

heff and others added 9 commits May 9, 2014 10:56

Made negative LESS calculations a little more readable.

4bb3a23

Added line to the changelog for PR merge.

Merge branch 'stable'

0156742

remove bunyip example and browsers.json files

3667d38

Made vjs.get work with xDomain in IE < 10. closes videojs#1095

047bd8f

Added support for playbackRate switching. closes videojs#1132

8dfe0a4

No need for a separate localkarma conf

617319e

Rename localkarma conf files to karma conf files

d97f143

Add a bunch of browsers for running with test task

e999af5

gkatsev mentioned this pull request May 14, 2014

Karma local sauce #1206

Closed

heff added 3 commits May 14, 2014 15:04

Fixed the loadstart event listener order so it's attached before the …

bad5130

…HTML5 tech triggers it. fixes videojs#1208 fixes videojs#1207 fixes videojs#1193

Fixed issues from comments on d7f840a

0c3fb04

- use triple equals - don't block play call on error

Added a missing changelog item

97c1f83

heff reviewed May 14, 2014
View reviewed changes

Merge branch 'karma-chameleon' of github.com:gkatsev/video.js into gk…

8c6dc84

…atsev-karma-chameleon Conflicts: package.json

heff reviewed May 15, 2014
View reviewed changes

heff and others added 5 commits May 14, 2014 17:24

Added sinon to the test files

6c7a914

Merge pull request #1 from heff/gkatsev-karma-chameleon

6dfc9a7

Gkatsev karma chameleon

use karma-sinon

16a263e

Add a common 'pretask'

070edd6

Init and dispose of tech on setup and teardown.

1a64dbd

heff reviewed May 16, 2014
View reviewed changes

Gruntfile.js

chromecanary: {

browsers: ['ChromeCanary']

},

chrome: {

Copy link

Member

heff May 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does having these individual browser definitions get us?

Add some comments explaining the test task

891f39f

heff closed this in 3189ec1 May 16, 2014

gkatsev deleted the karma-chameleon branch May 17, 2014 00:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Karma chameleon #1187

Karma chameleon #1187

gkatsev commented May 1, 2014

gkatsev commented May 14, 2014

gkatsev commented May 14, 2014

gkatsev commented May 14, 2014

heff May 14, 2014

gkatsev May 15, 2014

gkatsev May 16, 2014

heff May 15, 2014

gkatsev May 15, 2014

heff May 15, 2014

heff May 15, 2014

heff May 16, 2014

Karma chameleon #1187

Karma chameleon #1187

Conversation

gkatsev commented May 1, 2014

gkatsev commented May 14, 2014

gkatsev commented May 14, 2014

gkatsev commented May 14, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment