Dmlap Merge Changes #1039
Closed
Dmlap Merge Changes #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new grunt task to create a new release version. It can be run like this: grunt dist version:patch Running dist before the version task is required so the build artifacts are available. The task uses `npm version` to bump the package version, copies the new version into the bower file and then force commits the dist directory in one shot. If that's successful, the dist directory is deleted in another commit so that no one accidentally makes patches against those files.
Create three smaller release tasks: check-for-changes, version, and commit-version. Add a roll-up task to execute them in the proper order. To create a minor release, you would run: grunt release --type=minor
If pause was called on the SWF before the video started playing, it would be silently ignored. This new version ensures that does not happen.
Our .gitignore excludes the dist/ directory but we definitely want dist/ to be available for npm. Copied over the current .gitignore and removed the entry for dist.
We were checking if `backgroundSize` was present on the video element, not the style property of the video element. That meant the IE fallback was being used on all platforms and breaks aspect-ratio preserving poster scaling for those browsers that support it.
Use the netstream to determine buffered endpoint when duration is unavailable.
Buffered shouldn't break for non-data gen content. Video dimension events on the netstream should be handled appropriately.
When the netstream is in data generation mode, buffering must take the last seek into account.
Instead of caching the last seek time at the player level, cache it in the Flash tech. The only place this value was used was in the progress controls when Flash was loaded, so this simplifies the logic in that component and pushes the hack down into a single location at least.
TOUCH_ENABLED is false on non-touch devices which causes our minified API test to fail when opened in a browser on a traditional destktop machine. It worked fine through the command line because apparanetly phantomjs supports touch events (ha!). Check to make sure the property is not undefined instead.
Consolidate stream start offset logic in HTTPVideoProvider
It can be handy that src() returns the player object when it is invoked but it does not match the behavior of the corresponding property on the video element. Ignoring the spec however, while the video element is running the resource selection algorithm, currentSrc may be undefined. If the video source has been specified through an attribute on the video element, src() is the natural way to expose that URL programmatically. Without this change, it's necessary to bypass the player and interact with the tech directly to determine the value of the src attribute.
Seek behavior looks out of sync with the latest from vjs-swf. Updating to pick up changes.
Pick up addition of endOfStream function to allow media sources to signal when the underlying video data is finishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from @dmlap repo