feat: implement spatial navigation #8570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds spatialNavigation feature to enhance user experience - Implemented spatial navigation in slider component - Enhanced player functionality for improved navigation
Adds spatialNavigation class to manage spatial-navigation-polyfill - Set class SpatialNavigation on its own file - Imported SpatialNavigation class on component class
Adds 3 methods to spatialNavigation class to manage spatial-navigation-polyfill - Added start() to: Start listen of keydown events - Added stop() to: Stop listen key down events - Added getComponents() to: Get current focusable components
Modify spatialNavigation class: -Remove unrequired version of function ‘getComponents’ Modify component class: -Add function ‘getIsFocusable’
… into spatial-navigation
…Component class Modify Component class: -Add method getIsAvailableToBeFocused -Modify method getIsFocusable to only focus on finding focusable candidates Modify spatialNavigation class: -Remove unrequired method ‘getIsFocusable’ Modify component class: -Remove unrequired method ‘getIsFocusable’
Modify Component class: -Modify method getIsAvailableToBeFocused to be more strict on candidates Modify spatialNavigation class: -Modify method getComponents to get all focusable components
Modify Component class: -Add documentation to ‘isVisible’ function
Modify SpatialNavigation class: -Modify documentation of functions
Modify SpatialNavigation class: -Add ‘clear’ & ‘remove’ methods
Modify SpatialNavigation class: -Add documentation of functions
Modify SpatialNavigation class: -Add function ‘getCurretComponent’‘’
Modify SpatialNavigation class: -Add documentation for ‘findBestCandidate’ method
…ance methods for spatial navigation logic
…ntrol-bar for spatial-navigation-polyfill needs
Modify SpatialNavigation class: -Add function ‘handlePlayerBlur’ -Add function ‘handlePlayerFocus’ Modify Component class: -Modify ‘handleBlur’ -Modify ‘handleFocus’
…avigation manually
feat(player): modify SpatialNavigation class & Component class
…(custom event focusableComponentsChanged)
… class Modify SpatialNavigation class: -Add ‘lastFocusedComponent’ -Add function ‘refocusComponent’ Modify ModalDialog class: -Add condition on ‘close’ function Modify Component class: -Modify ‘handleBlur’ to store blurred component
feat(player): modify SpatialNavigation class, ModalDialog & Component class
Modify ModalDialog: -Add condition to close Modal on Backspace
Refactor SpatialNavigation to use player.spatialNavigation
Move handleFocus and handleBlur from components.js to spatial-navigation.js
…e spatial navigation
…fortrack refactor(player): refactor 'searchForTrackSelect' to be handled in the spatial navigation.
…atial navigation class, modify the modal-dialog test accordingly
… into update-modal-dialog
remove spatial navigation keydown from modal dialog and move it to spatial navigation class, modify the modal-dialog test accordingly
… into spatial-navigation
dzianis-dashkevich
approved these changes
Apr 17, 2024
wseymour15
approved these changes
Apr 17, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances VideoJS by introducing spatial navigation functionality, allowing users to navigate through focusable components within the player using arrow keys.
Spatial Navigation guide videojs/videojs.com#190
Specific Changes proposed
Requirements Checklist