-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requestVideoFrameCallback broken for audio players #7807
Comments
Should be fixed in 7.20.1 via #7778 |
my fault, i searched issues but not PRs |
No worries |
With version 7.20.1 I get the exact same error. I've added an example of my code in the following sandbox: https://codesandbox.io/s/zen-rubin-grq8sr |
yeah, i just confirmed it. looks like this.setSource (src/js/tech/html5.js:47) calls requestVideoFrameCallback before src/js/tech/html5.js:117 has a chance to say it's not supported on this element. |
@TimmNL for now you can omit the |
…ce (videojs#7812) the tech needs to know whether or not the underlying element supports requestVideoFrameCallback before calling setSource Fixes videojs#7807
Description
initializing a videojs object on an element in a browser that supports requestVideoFrameCallback results in an error because requestVideoFrameCallback is not available on an element.
Reduced test case
No response
Steps to reproduce
Errors
video.es.js:20691 Uncaught TypeError: this.el_.requestVideoFrameCallback is not a function
at Html52.requestVideoFrameCallback (video.es.js:20691:23)
at TextTrack2.startTracking (video.es.js:7972:28)
at new TextTrack2 (video.es.js:7813:13)
at new HTMLTrackElement2 (video.es.js:8298:17)
at Html52.createRemoteTextTrack (video.es.js:9223:12)
at Html52.createRemoteTextTrack (video.es.js:20826:52)
at Html52.addRemoteTextTrack (video.es.js:9254:33)
at Html52.addRemoteTextTrack (video.es.js:20872:63)
at new MasterPlaylistController2 (video.es.js:51098:40)
at VhsHandler2.src (video.es.js:54512:38)
What version of Video.js are you using?
7.19.2
Video.js plugins used.
none
What browser(s) including version(s) does this occur with?
Chrome 102
What OS(es) and version(s) does this occur with?
MacOS 12.4
The text was updated successfully, but these errors were encountered: