fix: don't always use fastSeek when available. #7527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were always setting `scrubbing(true)` on mouse down. This means, that we'd use `fastSeek` even when seeking while clicking, rather than only when scrubbing. The main fix involves knowing in `handleMouseMove` whether we were called directly as a `mousemove` handler or whether it was called from `handleMouseDown`. This means that when `handleMouseMove` is called via `handleMouseDown` we can skip setting `scrubbing(true)` and only do it when we are scrubbing directly.
This was referenced Nov 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #7527 +/- ##
==========================================
+ Coverage 79.84% 80.26% +0.41%
==========================================
Files 116 116
Lines 7309 7321 +12
Branches 1764 1769 +5
==========================================
+ Hits 5836 5876 +40
+ Misses 1473 1445 -28
Continue to review full report at Codecov.
|
gesinger
reviewed
Nov 17, 2021
gesinger
reviewed
Nov 17, 2021
Co-authored-by: Garrett Singer <[email protected]>
gesinger
approved these changes
Nov 17, 2021
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
We were always setting `scrubbing(true)` on mouse down. This means, that we'd use `fastSeek` even when seeking while clicking, rather than only when scrubbing. The main fix involves knowing in `handleMouseMove` whether we were called directly as a `mousemove` handler or whether it was called from `handleMouseDown`. This means that when `handleMouseMove` is called via `handleMouseDown` we can skip setting `scrubbing(true)` and only do it when we are scrubbing directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always setting
scrubbing(true)on mouse down. This means, thatwe'd use
fastSeekeven when seeking while clicking, rather than onlywhen scrubbing.
The main fix involves knowing in
handleMouseMovewhether we werecalled directly as a
mousemovehandler or whether it was called fromhandleMouseDown. This means that whenhandleMouseMoveis called viahandleMouseDownwe can skip settingscrubbing(true)and only do itwhen we are scrubbing directly.
Fixes #6988, fixes #7360