Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitup seeking handling from mousemove handler #7531

Open
gkatsev opened this issue Nov 17, 2021 · 1 comment
Open

Splitup seeking handling from mousemove handler #7531

gkatsev opened this issue Nov 17, 2021 · 1 comment
Labels
outdated Things closed automatically by stalebot

Comments

@gkatsev
Copy link
Member

gkatsev commented Nov 17, 2021

This is a follow-up from #7527. That PR is a quickfix to us not marking a click-to-seek as scrubbing so that we won't use fastSeek for those and only use fastSeek when we're actually scrubbing.
Ideally, we'd want to pull out the seeking logic out of the mousemove handler and have both mousedown and mousemove handlers call the seeking logic.
Doing so would also affect the Slider, which means that it'll affect the volume bar as well, so, we'd need to make sure that's all set up properly.

@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated Things closed automatically by stalebot
Projects
None yet
Development

No branches or pull requests

1 participant