Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio desync when scrubbing around videos #6722

Closed
ctd1500 opened this issue Jun 23, 2020 · 2 comments · Fixed by #6752
Closed

Audio desync when scrubbing around videos #6722

ctd1500 opened this issue Jun 23, 2020 · 2 comments · Fixed by #6752

Comments

@ctd1500
Copy link
Contributor

ctd1500 commented Jun 23, 2020

Description

I was in the process of updating my build of video.js and I noticed major audio desync issues in Firefox when seeking around videos.
My testing shows that the issue seems to be caused by the FastSeek feature #6525

I created two examples built from the Main branch to reproduce this:
FastSeek feature causing desync: https://codesandbox.io/s/videojs-fastseek-test-gvvx0
FastSeek commit reverted, fixes desync: https://codesandbox.io/s/videojs-fastseek-removed-test-94tnc

Steps to reproduce

Seek around the video in the FastSeek feature example and you'll start to see audio desync.
An easily recognizable example would be the bird at 00:20.

Results

Expected

No desync

Actual

Major audio desync

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

Main branch

browsers

Firefox 77

OSes

All OSes (tested on Windows 10, and Mac via BrowserStack)

@gkatsev
Copy link
Member

gkatsev commented Jun 24, 2020

Huh, it's with an mp4? We don't handle playback of that ourselves. Sounds like we probably want to limit the functionality to safari and then expand it to our source handlers whenever we get around to implementing iframes in VHS.

@gkatsev
Copy link
Member

gkatsev commented Jul 13, 2020

This is probably something that we should report to Mozilla as well because we don't handle things like mp4 playback. Adding a PR to limit fastSeek to only Safari based browsers.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
edirub pushed a commit to edirub/video.js that referenced this issue Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants