-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In iOS, fullscreenchange event is not firing while exit from the full screen #6645
Comments
👋 Thanks for opening your first issue here! 👋 If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
same here .
That's all. |
can you try this ? I had a similar use case #6574 |
Thank you for everyone's patience. We have a potential fix for this with #6735. You can give it a shot here https://deploy-preview-6735--videojs-docs.netlify.app/test-example/. If you do, please let us know if it fixes the issue for you. |
The Fullscreen API is unsupported in iOS, so self.fsApi_.fullscreenerror and self.fsApi_.fullscreenchange are undefined, which was breaking the player after entering fullscreen by removing all bound player events. Fixes videojs#6707, fixes videojs#6684, fixes videojs#6645.
Description
In iOS safari browser, when I am clicking on fullscreen icon fullscreenchange event is triggering.
The same event should be trigger while clicking on Exit fullscreen icon. But it's not triggering.
Results
Expected
fullscreenchange event should be trigger on both the fullscreen & exit fullscreen mode.
Actual
fullscreenchange is not triggering.
Additional Information
This issue might be on because of #6424 . Still I am not sure.
When ever clicks on the fullscreen icon in the iOS safari browser, native player starts to play the video in fullscreen and also triggers the fullscreenerror event. On fullscreenerror, it's removing the following listener fullscreenchange, fullscreenerror. DomData (fullscreenchange,fullscreenerror) WeakMap reference also got removed. Dispatcher & elem is not available while running this code
this.trigger('fullscreenchange', {isFullscreen: false});
versions
videojs
7.8.1
browsers
Mobile Safari
OSes
iOS
The text was updated successfully, but these errors were encountered: