Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fastSeek during scrubbing if available #6525

Merged
merged 12 commits into from
Apr 22, 2020
Merged

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Mar 13, 2020

This can be tested on Safari with a HLS playlist containing iframes, for example https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_adv_example_hevc/master.m3u8

@gkatsev
Copy link
Member Author

gkatsev commented Mar 13, 2020

Should add some doccomments and maybe a test or two as well.

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Apr 21, 2020
@alex-barstow
Copy link
Contributor

What exactly is the behavior I should be observing in Safari? I'm not able to discern any difference between using fastSeek() and currentTime().

@gkatsev
Copy link
Member Author

gkatsev commented Apr 22, 2020

You need to use an HLS playlist with iframe playlists. When it's available, using fastSeek will switch to using iframes during scrubbing, i.e., when you click and drag on the progress bar. This should allow for thumbnail-like behavior during seeking and should help load from the final point faster without downloading as much data as during regular scrubbing.
This will also open us up to be able to implement this feature in VHS.

@alex-barstow
Copy link
Contributor

I see an iframe playlist loaded, but the scrubbing doesn't appear any smoother or faster than non-iframe scrubbing.

@gkatsev
Copy link
Member Author

gkatsev commented Apr 22, 2020

Yeah, I'm not really sure how well it works but it would still download less data during scrubbing, so, as long as it's not worse, should be good.

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem like an improvement for seeking in this specific case on safari compared to other videos. 👍

Copy link
Contributor

@alex-barstow alex-barstow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkatsev gkatsev merged commit 8c66c58 into master Apr 22, 2020
@gkatsev gkatsev deleted the fast-seek branch April 22, 2020 16:40
@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants