-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support fastSeek during scrubbing if available #6525
Conversation
Should add some doccomments and maybe a test or two as well. |
What exactly is the behavior I should be observing in Safari? I'm not able to discern any difference between using |
You need to use an HLS playlist with iframe playlists. When it's available, using fastSeek will switch to using iframes during scrubbing, i.e., when you click and drag on the progress bar. This should allow for thumbnail-like behavior during seeking and should help load from the final point faster without downloading as much data as during regular scrubbing. |
I see an iframe playlist loaded, but the scrubbing doesn't appear any smoother or faster than non-iframe scrubbing. |
Yeah, I'm not really sure how well it works but it would still download less data during scrubbing, so, as long as it's not worse, should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem like an improvement for seeking in this specific case on safari compared to other videos. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This can be tested on Safari with a HLS playlist containing iframes, for example https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_adv_example_hevc/master.m3u8