-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles/captions button is named incorrectly in the docs #5980
Comments
👋 Thanks for opening your first issue here! 👋 If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
The docs in |
That isn't incorrect. We do have a SubtitlesButton and a CaptionsButton. We default to a SubsCapsButton now (which should be on there but isn't). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Add SubsCapsButton, SeekToLive and LiveTracker. Fixes #5980.
Add SubsCapsButton, SeekToLive and LiveTracker. Fixes #5980.
Hello,
Please update the list of components here: https://docs.videojs.com/tutorial-components.html
...and here: https://docs.videojs.com/docs/guides/components.html
...to include the correct button name for subtitles/caption.
As I found at https://github.com/videojs/video.js/blob/master/src/js/control-bar/control-bar.js it should be 'subsCapsButton'
It took me a couple of hours to find that (specifically, to disable that button), so will definitely save someone's time in the future.
This is for the latest video.js version at least.
The text was updated successfully, but these errors were encountered: