fix: audio and video track changes #5890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
fix/audio-video-tracks
branch
from
1cf7130 to
52c8cc7
Compare
brandonocasey
commented
Mar 25, 2019
| assert.equal(track.enabled, true, 'track is disabled'); | ||
| assert.equal(track2.enabled, false, 'track2 is disabled'); | ||
| track2.enabled = true; | ||
| assert.equal(track.enabled, false, 'track is disabled'); |
There was a problem hiding this comment.
We did not test to make sure that a track that is not enabled and already added, would be enabled correctly. Same with video tracks
|
Confirmed locally that the test updates fail and with the change they succeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5887
trying to find out why the unit tests didn't catch this, 🤔Tests fixed