Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio track selection is broken in v7.5.1 on Chrome/Firefox #5887

Closed
0caspy opened this issue Mar 23, 2019 · 3 comments · Fixed by #5890
Closed

Audio track selection is broken in v7.5.1 on Chrome/Firefox #5887

0caspy opened this issue Mar 23, 2019 · 3 comments · Fixed by #5890

Comments

@0caspy
Copy link

0caspy commented Mar 23, 2019

Description

Audio track selection is broken in v7.5.1 on Chrome/Firefox

Steps to reproduce

  1. setup any HLS stream with more than one audio (even bipbop) with v 7.5.1
  2. start video
  3. try to change audio track

Results

Expected

Audio track changed, menu-list correctly rendered.

Actual

Chrome/Firefox on macOS:
Audio track NOT changed, menu-list incorrectly rendered.

Error output

no errors

Additional Information

on 7.5.0 there is no this issue. appeared only on 7.5.1

versions

videojs

v 7.5.1

browsers

Chrome 72, Firefox 65

OSes

macOS Mojave

plugins

no plugins

@0caspy
Copy link
Author

0caspy commented Mar 23, 2019

commit 142cc67 (changes to src/js/tracks/audio-track-list.js) introduce this behaviour.

reverting back addeventlistener to:
track.addEventListener('enabledchange', () => {...code here...});
recovers audio track switching.

@gkatsev
Copy link
Member

gkatsev commented Mar 25, 2019

Thanks, we'll take a look.

@gkatsev
Copy link
Member

gkatsev commented Mar 25, 2019

Should be fixed in 7.5.2. Thanks for opening the issue!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants