Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A gap appears underneath a player that takes up the entire page, such as in an iframe embed #5351

Closed
DoomTay opened this issue Jul 27, 2018 · 4 comments · May be fixed by CleverTap/vue-video-player#3

Comments

@DoomTay
Copy link
Contributor

DoomTay commented Jul 27, 2018

On a minimal example, this only comes up in Firefox, but in a real-world implementation, not only would it happen in Chrome as well, but on Chrome, the scrollbar would rapidly appear and disappear

Here is a minimal use case, along with a real-world example

@gkatsev
Copy link
Member

gkatsev commented Jul 30, 2018

So, a workaround for this is to add scrolling="no" to the iframe embeds.

In Chrome, locally, it actually works fine but I do see it in Firefox.

Investigating it, it seems like the progress-control is the one that causes this issue.

@gkatsev
Copy link
Member

gkatsev commented Jul 30, 2018

Looks like it's the time tooltip of the play progress bar that causes the overflow.

@gkatsev
Copy link
Member

gkatsev commented Jul 30, 2018

Seems like the fix is pretty easy to just change position: relative to position: absolute for the tooltips?

@gkatsev
Copy link
Member

gkatsev commented Jul 30, 2018

I've create this issue for first timers to supply a fix #5354

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants