-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen button should be removed or greyed out when fullscreen is unavailable #5290
Comments
Looks like we can check Would you be interested in making the change? |
Sure, sounds pretty simple |
Description
See title.
Example use case: an iframe that doesn't have the allowfullscreen attribute. The given starter template is such an example
Results
Expected
Fullscreen button should be removed or greyed out
Actual
Fullscreen button appears functional, but clicking on it does nothing. It takes looking at the console to see that it's because the containing iframe doesn't have the allowfullscreen attribute
Error output
If there are any errors at all, please include them here.
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
7.0.5
browsers
Firefox 60.0.2
OSes
Windows 10
plugins
None
The text was updated successfully, but these errors were encountered: