Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind up/down arrows for volume control #492

Closed
jrw95 opened this issue May 8, 2013 · 3 comments
Closed

Bind up/down arrows for volume control #492

jrw95 opened this issue May 8, 2013 · 3 comments

Comments

@jrw95
Copy link
Contributor

jrw95 commented May 8, 2013

Brightcove recently implemented a vertical volume control and slider, and I noticed in testing today that only the left and right arrows control the volume setting.

I'd argue that using the up and down arrows would be at least as natural as using the left and right, at least in setting something like volume (which by its definition goes "up" and "down" in the user's perception).

@heff
Copy link
Member

heff commented May 8, 2013

Yeah, that makes sense. I can't think of a reason not to make both work for sliders in general.

On May 8, 2013, at 10:54 AM, BCjwhisenant [email protected] wrote:

Brightcove recently implemented a vertical volume control and slider, and I noticed in testing today that only the left and right arrows control the volume setting.

I'd argue that using the up and down arrows would be at least as natural as using the left and right, at least in setting something like volume (which by its definition goes "up" and "down" in the user's perception).


Reply to this email directly or view it on GitHub.

@gkatsev
Copy link
Member

gkatsev commented May 8, 2013

Yeah, this should apply to the general slider.

@heff
Copy link
Member

heff commented May 20, 2014

This one's still up for grabs if anyone wants to work on it.

@heff heff closed this as completed in bb93a18 Jul 28, 2014
heff added a commit that referenced this issue Jul 28, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants