Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest build fail, HEAD is now at 79639138 #4706

Closed
kocoten1992 opened this issue Oct 31, 2017 · 2 comments
Closed

Latest build fail, HEAD is now at 79639138 #4706

kocoten1992 opened this issue Oct 31, 2017 · 2 comments

Comments

@kocoten1992
Copy link
Contributor

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. git clone https://github.com/videojs/video.js
  2. npm install
  3. npm run test

It fail by open() hides controls, close() shows controls at test/unit/modal-dialog.test.js
@kocoten1992 kocoten1992 mentioned this issue Oct 31, 2017
Merged
1 task
@mister-ben
Copy link
Contributor

I believe #4690 is causing this

@gkatsev
Copy link
Member

gkatsev commented Oct 31, 2017

Thanks, yeah, I noticed that it was failing after merging in but didn't have the time to fix it last night.

gkatsev added a commit that referenced this issue Oct 31, 2017
@gkatsev
test: fix modal dialog test for showing controls
97d6fe0 
Also, add a test that verifies the behavior for the PR (#4690).

Fixes #4706.
@gkatsev gkatsev mentioned this issue Oct 31, 2017
Merged
gkatsev added a commit that referenced this issue Oct 31, 2017
@gkatsev
test: fix modal dialog test for showing controls (#4707)
45a6b30 
Also, add a test that verifies the behavior for the PR (#4690).

Fixes #4706.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gkatsev @mister-ben @kocoten1992