Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore: get rid of redundant test logging #4682

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Conversation

brandonocasey
Copy link
Contributor

Description

Currently you have to specify a second param in addRemoteTextTrack so that it does not log. This causes a few lines to log for every browser, which can make things a bit confusing.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Should be merged as test, not ignore.

@brandonocasey brandonocasey merged commit 983a573 into master Oct 23, 2017
@gkatsev gkatsev deleted the ignore/test-logging branch October 23, 2017 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants