Hebrew translation #4675
Merged
Hebrew translation #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hebrew translation for VideoJS
gkatsev
reviewed
Oct 19, 2017
lang/he.json
Outdated
| "Loaded": "נטען", | ||
| "Progress": "התקדמות", | ||
| "Progress Bar": "סרגל התקדמות", | ||
| "progress bar timing: currentTime={1} duration={2}": "{1} מתוך {2}}", |
There was a problem hiding this comment.
Is this malformed or just rendering issues? Maybe there's just an extra } at the end/beginning?
There was a problem hiding this comment.
I think it only appears weird because Hebrew is RTL and numbers are LTR.
Ill give it another test run to make sure it appears properly in the player itself and get back to you.
fixed double curly braces for translation of entry "progress bar timing: currentTime={1} duration={2}"
gkatsev
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hebrew translation for VideoJS.
Reviews welcome 😁