Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.x fix: synchronously shim vtt.js when possible #4082

Merged
merged 1 commit into from
Feb 21, 2017
Merged

5.x fix: synchronously shim vtt.js when possible #4082

merged 1 commit into from
Feb 21, 2017

Conversation

brandonocasey
Copy link
Contributor

Description

Fix a bug where vtt.js would shim window.WebVTT way to late in the pipeline.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@brandonocasey brandonocasey mentioned this pull request Feb 14, 2017
Merged
4 tasks
@brandonocasey brandonocasey changed the title synchronously shim vtt.js when possible 6.x fix: synchronously shim vtt.js when possible Feb 14, 2017
@brandonocasey brandonocasey changed the title 6.x fix: synchronously shim vtt.js when possible 5.x fix: synchronously shim vtt.js when possible Feb 21, 2017
@brandonocasey brandonocasey merged commit b5727a6 into 5.x Feb 21, 2017
@gkatsev gkatsev deleted the fix/webvtt-shim-sync branch March 24, 2017 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @misteroneill