Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-valuenow and aria-valuetext are not initially set correctly #4021

Closed
OwenEdwards opened this issue Feb 2, 2017 · 0 comments · Fixed by #4023
Closed

aria-valuenow and aria-valuetext are not initially set correctly #4021

OwenEdwards opened this issue Feb 2, 2017 · 0 comments · Fixed by #4023
Assignees
Labels
a11y This item might affect the accessibility of the player

Comments

@OwenEdwards
Copy link
Member

Description

The initial state of the volume slider has aria-valuenow set to 0, and no aria-valuetext attribute. As a result, a screen reader (e.g. VoiceOver on macOS) announces the slider as "0, volume level), even though the volume is set to (and displayed as) 100%. The aria-valuetext is not set until the volume is changed.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. On a Mac, turn on VoiceOver (command-F5)
  2. Open a page with the video.js player, in Safari
  3. Use the Tab key to move keyboard focus to the Big Play Button, and press Enter
  4. Use the Tab key to move focus into the Control Bar, and then onto the volume control slider

Results

Expected

Expect VoiceOver to announce (and display) that the volume is 100%

Actual

VoiceOver announces "0, volume level"

Error output

None

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

v6.0.0-RC.1

browsers

Safari with VoiceOver (and probably others)

OSes

macOS (Sierra, 10.12.2)

plugins

No

@OwenEdwards OwenEdwards added the a11y This item might affect the accessibility of the player label Feb 2, 2017
brandonocasey added a commit that referenced this issue Feb 2, 2017
* Fixes #4021: drop the decimal places on aria-valuenow and aria-valuetext
* Fixes #4022: aria-valuenow and aria-valuetext not set initially
brandonocasey added a commit that referenced this issue Feb 2, 2017
* Fixes #4021: drop the decimal places on aria-valuenow and aria-valuetext
* Fixes #4022: aria-valuenow and aria-valuetext not set initially
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This item might affect the accessibility of the player
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants