Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with TOUCH_ENABLED in browser.js with touch screen and Windows 10 and Windows Phone 10 #3306

Closed
PatrikCarlander opened this issue May 9, 2016 · 5 comments
Labels
good first issue help wanted pinned Things that stalebot shouldn't close automatically

Comments

@PatrikCarlander
Copy link

PatrikCarlander commented May 9, 2016

Current code:

TOUCH_ENABLED = !!(('ontouchstart' in window) || window.DocumentTouch && document instanceof window.DocumentTouch);

This evaluate false with Windows 10 with touch screen and Browser: IE11, Edge and also with Windows Phone 10 and Edge,
it evaluate true with Windows 10 and Browser: Chrome 50

Here is a bug fix:

TOUCH_ENABLED = !!(('ontouchstart' in window) || window.navigator.maxTouchPoints || window.DocumentTouch && document instanceof window.DocumentTouch);

This evaluate true with Windows 10 with touch screen and Browser: Chrome 50 and IE11, Edge and also with Windows Phone 10 and Edge.
With a Windows 10 computer without touch screen it evaluate false as it should.

@gkatsev
Copy link
Member

gkatsev commented May 9, 2016

Interesting. I guess they changed some stuff.
Care to submit a PR to fix this?

@s1iqbal
Copy link

s1iqbal commented Feb 6, 2018

Ill get on it.
Learned a bunch about git and git pulls, along with testing. Thank you!

s1iqbal pushed a commit to s1iqbal/video.js that referenced this issue Feb 6, 2018
TOUCH_ENABLED = !!(('ontouchstart' in window) || window.navigator.maxTouchPoints || window.DocumentTouch && document instanceof window.DocumentTouch);
This evaluate true with Windows 10 with touch screen and Browser: Chrome 50 and IE11, Edge and also with Windows Phone 10 and Edge.
@gkatsev
Copy link
Member

gkatsev commented Feb 28, 2018

@s1iqbal hey, did you want to make a PR for this?

@s1iqbal
Copy link

s1iqbal commented Mar 1, 2018

@gkatsev yes please

@gkatsev gkatsev removed the unclaimed label Mar 1, 2018
@gkatsev
Copy link
Member

gkatsev commented Mar 1, 2018

@s1iqbal Hey, seems like you have a commit with this change? Do you need help making it into a pull request?

@gkatsev gkatsev added the pinned Things that stalebot shouldn't close automatically label Jul 2, 2018
@gkatsev gkatsev closed this as completed in e683891 Jul 3, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue help wanted pinned Things that stalebot shouldn't close automatically
Projects
None yet
Development

No branches or pull requests

3 participants