-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with TOUCH_ENABLED in browser.js with touch screen and Windows 10 and Windows Phone 10 #3306
Labels
Comments
Interesting. I guess they changed some stuff. |
Ill get on it. |
s1iqbal
pushed a commit
to s1iqbal/video.js
that referenced
this issue
Feb 6, 2018
TOUCH_ENABLED = !!(('ontouchstart' in window) || window.navigator.maxTouchPoints || window.DocumentTouch && document instanceof window.DocumentTouch); This evaluate true with Windows 10 with touch screen and Browser: Chrome 50 and IE11, Edge and also with Windows Phone 10 and Edge.
@s1iqbal hey, did you want to make a PR for this? |
@gkatsev yes please |
@s1iqbal Hey, seems like you have a commit with this change? Do you need help making it into a pull request? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Current code:
This evaluate false with Windows 10 with touch screen and Browser: IE11, Edge and also with Windows Phone 10 and Edge,
it evaluate true with Windows 10 and Browser: Chrome 50
Here is a bug fix:
This evaluate true with Windows 10 with touch screen and Browser: Chrome 50 and IE11, Edge and also with Windows Phone 10 and Edge.
With a Windows 10 computer without touch screen it evaluate false as it should.
The text was updated successfully, but these errors were encountered: