Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadstart getting triggered twice #2588

Closed
misteroneill opened this issue Sep 14, 2015 · 3 comments · Fixed by #2605
Closed

loadstart getting triggered twice #2588

misteroneill opened this issue Sep 14, 2015 · 3 comments · Fixed by #2605
Milestone

Comments

@misteroneill
Copy link
Member

This may be related to #1194

@heff heff added this to the v5.0.0 milestone Sep 14, 2015
@mmcc
Copy link
Member

mmcc commented Sep 14, 2015

There were also older issues that talked about similar things and if related, I don't think there's much we can do about it. IIRC, at least when preload is set to auto or true, the browser would start loading the file before VJS swaps the video element into the new wrapper div, then the second loadstart event is fired. I could be wrong, but I'll try to find the older issue when I get to a better internet connection.

@misteroneill
Copy link
Member Author

FWIW, this appears to be a new issue in 5.0. It was revealed by a test for the videojs-contrib-ads plugin when I upgraded it for 5.0 compatibility. I then ran the same test against the previous 4.x compatible version of the plugin and only one loadstart was triggered.

Here's a JSBin demonstrating it: http://jsbin.com/xejigukepa/1/edit?html,console,output

@mmcc
Copy link
Member

mmcc commented Sep 14, 2015

Ah bummer, that blows that theory to smithereens.

On Mon, Sep 14, 2015 at 1:28 PM misteroneill [email protected]
wrote:

FWIW, this appears to be a new issue in 5.0. It was revealed by a test for
the videojs-contrib-ads plugin when I upgraded it for 5.0 compatibility. I
then ran the same test against the previous 4.x compatible version of the
plugin and only one loadstart was triggered.

Here's a JSBin demonstrating it:
http://jsbin.com/xejigukepa/1/edit?html,console,output


Reply to this email directly or view it on GitHub
#2588 (comment).

heff added a commit to heff/video.js that referenced this issue Sep 18, 2015
 - Fixed some issue comments
 - Fixed a double ready event

closes videojs#2605
fixes videojs#2588
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants