-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vjs-user-active
or vjs-user-inactive
aren't added by default
#2550
Comments
What's the result of not having it? Could we just add it on init? |
Yep, basically, things that depend on those don't work quite right immediately after pressing play. |
Yeah, I feel like we can consider the user active when the player is initialized. It at least seems better to have a default state from init instead of waiting until some point later. We could start there and see if it does what we need. |
Looks like we already try doing something like this: https://github.com/videojs/video.js/blob/master/src/js/player.js#L202 |
Only until the first triggered event happens does one of these get added.
vjs-user-active
should probably be added by default on first play since at that time the user is definitely active.The text was updated successfully, but these errors were encountered: