Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vjs-user-active or vjs-user-inactive aren't added by default #2550

Closed
gkatsev opened this issue Sep 3, 2015 · 4 comments
Closed

vjs-user-active or vjs-user-inactive aren't added by default #2550

gkatsev opened this issue Sep 3, 2015 · 4 comments

Comments

@gkatsev
Copy link
Member

gkatsev commented Sep 3, 2015

Only until the first triggered event happens does one of these get added.
vjs-user-active should probably be added by default on first play since at that time the user is definitely active.

@heff
Copy link
Member

heff commented Sep 3, 2015

What's the result of not having it? Could we just add it on init?

@gkatsev
Copy link
Member Author

gkatsev commented Sep 3, 2015

Yep, basically, things that depend on those don't work quite right immediately after pressing play.
Not certain whether just adding user active on init is a good idea but a lot of css selectors also check for vjs-has-started, so, maybe not a huge issue in that respect.

@heff
Copy link
Member

heff commented Sep 3, 2015

Yeah, I feel like we can consider the user active when the player is initialized. It at least seems better to have a default state from init instead of waiting until some point later. We could start there and see if it does what we need.

@gkatsev
Copy link
Member Author

gkatsev commented Sep 4, 2015

Looks like we already try doing something like this: https://github.com/videojs/video.js/blob/master/src/js/player.js#L202
Looking into switching it out with this.userActive(true) instead.

@gkatsev gkatsev closed this as completed in 1f5a83d Sep 4, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants