Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using custom controls and poster on iphones #2365

Closed
gkatsev opened this issue Jul 16, 2015 · 5 comments
Closed

using custom controls and poster on iphones #2365

gkatsev opened this issue Jul 16, 2015 · 5 comments
Assignees
@gkatsev
Milestone
v5.0.0

Comments

@gkatsev
Copy link
Member

gkatsev commented Jul 16, 2015

Loading up the player on iphones will currently display our custom controls and our custom poster element. This is an issue because on some iOS versions, our big play button will not work. It seems like on iOS 8, it might work under some circumstances, but I'm not certain it will work across the board.
The best solution is probably to just hide our poster and controls on iphones.
Thoughts, @videojs/core-committers
@gkatsev gkatsev added this to the v5.0.0 milestone Jul 16, 2015
@gkatsev
Copy link
Member Author

gkatsev commented Jul 16, 2015

Also, videoEl.controls is always returning true on iphones, even if I specifically removeAttribute it.

@gkatsev gkatsev self-assigned this Jul 16, 2015
@gkatsev
Copy link
Member Author

gkatsev commented Jul 16, 2015

The issue is partly that the tech is supposed to trigger usingnativecontrols for the player to listen to but it gets triggered in the constructor, so, the player will never get the event.

gkatsev added a commit to gkatsev/video.js that referenced this issue Jul 16, 2015
@gkatsev
Use native controls on iphone.
a75fabb 
Fixes videojs#2365.
Also, wrap the trigger in a setTimeout. This is because otherwise, the
player will never be able to hear this event since it happens in the
constructor of the tech and the player adds listeners after the tech has
been created.
@gkatsev gkatsev mentioned this issue Jul 16, 2015
Closed
@dmlap
Copy link
Member

dmlap commented Jul 17, 2015

I'm inclined to continue displaying native controls on iPhones by default. We should probably take another pass at custom controls some point soon, though.

gkatsev added a commit to gkatsev/video.js that referenced this issue Aug 21, 2015
@gkatsev
Use native controls on iphone.
5d31bdf 
Fixes videojs#2365.
Also, wrap the trigger in a setTimeout. This is because otherwise, the
player will never be able to hear this event since it happens in the
constructor of the tech and the player adds listeners after the tech has
been created.
@heff
Copy link
Member

heff commented Sep 1, 2015

@gkatsev did a PR get merged for this?

@gkatsev
Copy link
Member Author

gkatsev commented Sep 1, 2015

Yes. This can be closed.

@gkatsev gkatsev closed this as completed Sep 1, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gkatsev gkatsev

Labels
None yet
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
3 participants
@heff @dmlap @gkatsev