Hack week (4/27) Issue Guide

[heff]

Today starts another Brightcove hackweek where engineers can work on whatever they want. This hack week we're attempting to finish off the remaining 5.0 tasks, and of course anyone outside of Brightcove is more than welcome to jump in and help (comment here if you're interested).

This list puts them in a sensible order so we're not stepping on each other's toes.

Easy, few files touched

Claim and complete at will, no order necessary

• Throw an error if tech isn't in options Throw an error if tech isn't in options #1998 (@dmlap, Throw an error if techOrder isn't in options. For #1998 #2097)
• Initialize the plugins before the components Initialize the plugins before the components #1980 (@bc-bbay, Load plugins before controls #2094)
• Make 'scrubbing' an official property Make 'scrubbing' an official property #1766 (@forbesjo)
• Process Changes for 5.0 Process Changes for 5.0 #1513 (@heff)
• Switch to standard minified file naming conventions Switch to standard minified file naming conventions #1013 (@dconnolly)
• Create a sensible toJSON for a vjs object. Create a sensible toJSON for a vjs object. #957
• Remove JSON shim to avoid eval() CSP issues Remove JSON shim to avoid eval() CSP issues #867
• Switch event.isDefaultPrevented() to event.defaultPrevented to comply with spec Switch event.isDefaultPrevented() to event.defaultPrevented to comply with spec #463
• Make es5-shim a dependency Make es5-shim a dependency #1687
• Expose utility functions Expose utility functions #1232

Harder, few files touched

Complete at will, but requires more knowledge of Video.js

• Determine API for externally subclassing components Determine API for externally subclassing components #2035
• Consider making triggerReady async Consider making triggerReady async #1667
• Move to border-box as the default CSS setting for skin elements Move to border-box as the default CSS setting for skin elements #1444
• Choose and improve one set of mute + volume controls Choose and improve one set of mute + volume controls #1553 (@mmcc)
• Change the classname vjs-control to vjs-button Change the classname vjs-control to vjs-button #1204 (@forbesjo)
• Increase the hit area for controls on mobile devices Increase the hit area for controls on mobile devices #396

Easy, many files touched

Should be done in the order listed, and probably after all 'few-file' tasks to avoid rebasing complications

1. Decide on a final var style Decide on a final var style #2034 (@gkatsev)
2. Breaking apart files Breaking apart files #2010 (@dconnolly)
3. Switch to 'handleClick' listener naming over 'onClick' Switch to 'handleClick' listener naming over 'onClick' #1761 (@bc-bbay, Refactor event handler names - onEvent -> handleEvent #2093)

Harder, many files touched

Do after the easy tasks

1. Move default options into the constructor Move default options into the constructor #2033

[heff]

Closing this since hackweek is over, but we're still making progress!