Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose and improve one set of mute + volume controls #1553

Closed
heff opened this issue Sep 30, 2014 · 4 comments
Closed

Choose and improve one set of mute + volume controls #1553

heff opened this issue Sep 30, 2014 · 4 comments

Comments

@heff
Copy link
Member

heff commented Sep 30, 2014

Currently we have two options for setting up the html of the mute and volume controls:

  1. As completely separate controls
  2. Combined as a MenuButton and the volume is hidden until the mute button is hovered over or tabbed to

The second option is relatively hidden however the new Brightcove player is actually using this as the base of all Brightcove players.

The two options complicate the CSS significantly and will create a divide between sets of skin files that rely on one or the other. For v5.0 we should simplify this down to one option, and hopefully make it possible to achieve both layouts. That will probably mean we need to start from scratch. At the same time we should break apart the volume menu button from extending the MenuButton class. They've become too different and that's part of what's added the CSS complication.

Related Issues: #1519

@heff heff added this to the v5.0.0 milestone Sep 30, 2014
@gkatsev
Copy link
Member

gkatsev commented Sep 30, 2014

Sounds like a plan.

@heff
Copy link
Member Author

heff commented Apr 26, 2015

We've essentially landed on the volume menu here, but the one research task left here I see is attempting to create the inline volume style using the volume menu button. Or at least the YouTube style where it expands within the control bar.

@dmlap
Copy link
Member

dmlap commented Apr 27, 2015

Note: We're keeping both versions of the volume, but standardizing on using the volume menu as the default for all major players (video.js default and Brightcove player).

@dmlap
Copy link
Member

dmlap commented Apr 29, 2015

Documented in the migration guide.

@dmlap dmlap closed this as completed Apr 29, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants