Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename zh.js to zh-CN.js #1826

Closed
Globulopolis opened this issue Jan 24, 2015 · 10 comments
Closed

Rename zh.js to zh-CN.js #1826

Globulopolis opened this issue Jan 24, 2015 · 10 comments

Comments

@Globulopolis
Copy link

I think it's better to rename simplified Chinese translation file to zh-CN. Or not?

@swordfeng
Copy link

Well, it's true... Use zh_CN is better,as is used in Linux.

@heff
Copy link
Member

heff commented Jan 26, 2015

@DevGavin, any feedback on this?

It depends on whatever are the most common values for the html tag lang attribute or the navigator defined language value. I'm not sure how to determine that, but if both are common we could have a file for each.

@mister-ben
Copy link
Contributor

If the document/browser lang is zh-CN and we have a translation for the more generic zh, I think that should be used rather than the default.

@DevGavin
Copy link
Contributor

Sorry that I was not checking my email for the last few days.

I think for the language of Chinese "zh", there are two major variations "zh-CN" and "zh-TW". Most people from the two places can understand both variations. I wouldn't worry about the UI confusion brought to people in one place by the language of the other. And I don't think there is a "generic" zh because difference also lies in the form of the characters. I would suggest having both zh-CN and zh-TW translations and name them in "language-countrycode" format. Are there browsers return "zh" only? If so, I would suggest to duplicate one of the two language files used more often. Do we have this kind of statistics?

@heff
Copy link
Member

heff commented Jan 29, 2015

It sounds like we're in agreement here. @Globulopolis, would you want to make a pull request for the change?

@Globulopolis
Copy link
Author

Unfortunately no @heff ( I can only report the issue. If someone can make the PR I would be greatly appreciated.

@DevGavin
Copy link
Contributor

@heff What is the agreement here? To rename the current zh to zh-CN and to create another zh-TW version? If yes, I can do this PR. But I would like to confirm with you guys first.

@heff
Copy link
Member

heff commented Jan 30, 2015

There's already a zh-TW, so I think we just need to rename the current zh to zh-CN.

@heff
Copy link
Member

heff commented Jan 30, 2015

Sorry, I linked the wrong file for zh-TW.
https://github.com/videojs/video.js/blob/master/lang/zh-TW.json

DevGavin added a commit to DevGavin/video.js that referenced this issue Feb 1, 2015
@DevGavin
Copy link
Contributor

DevGavin commented Feb 1, 2015

Done

@mmcc mmcc closed this as completed Jul 25, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants