-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename zh.js to zh-CN.js #1826
Comments
Well, it's true... Use zh_CN is better,as is used in Linux. |
@DevGavin, any feedback on this? It depends on whatever are the most common values for the html tag lang attribute or the navigator defined language value. I'm not sure how to determine that, but if both are common we could have a file for each. |
If the document/browser lang is |
Sorry that I was not checking my email for the last few days. I think for the language of Chinese "zh", there are two major variations "zh-CN" and "zh-TW". Most people from the two places can understand both variations. I wouldn't worry about the UI confusion brought to people in one place by the language of the other. And I don't think there is a "generic" zh because difference also lies in the form of the characters. I would suggest having both zh-CN and zh-TW translations and name them in "language-countrycode" format. Are there browsers return "zh" only? If so, I would suggest to duplicate one of the two language files used more often. Do we have this kind of statistics? |
It sounds like we're in agreement here. @Globulopolis, would you want to make a pull request for the change? |
Unfortunately no @heff ( I can only report the issue. If someone can make the PR I would be greatly appreciated. |
@heff What is the agreement here? To rename the current zh to zh-CN and to create another zh-TW version? If yes, I can do this PR. But I would like to confirm with you guys first. |
There's already a zh-TW, so I think we just need to rename the current zh to zh-CN. |
Sorry, I linked the wrong file for zh-TW. |
As discussed. videojs#1826 (comment)
Done |
I think it's better to rename simplified Chinese translation file to zh-CN. Or not?
The text was updated successfully, but these errors were encountered: