Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poster image doesn't show when Flash fallback is used and controls are disabled. #1625

Closed
mmcc opened this issue Oct 30, 2014 · 3 comments
Closed

Comments

@mmcc
Copy link
Member

mmcc commented Oct 30, 2014

<video id="my_video_1" class="video-js vjs-default-skin" poster="/images/some-awesome-picture.png" preload="auto" width="640" height="268" 
  data-setup='{ "techOrder": ["flash"] }'>
    <source src="http://vjs.zencdn.net/v/oceans.mp4" type='video/mp4'>
    <source src="http://vjs.zencdn.net/v/oceans.webm" type='video/webm'>
  </video>

Because of these styles, the poster will never be shown for a Flash player with controls disabled.

@campones
Copy link

.video-js.vjs-fullscreen.vjs-user-inactive {
cursor: none;
}

doesn't work for me with flash fallback on (rtmp stream) while fullscreen. I still have cursor

@heff
Copy link
Member

heff commented Dec 15, 2014

At one point I believe we had if (player.controls()) { this.play() } in the poster click handler. We could probably just add that back in and remove the CSS.

@gkatsev
Copy link
Member

gkatsev commented Nov 18, 2015

Still an issue for v5 for the same reason:

/* Hide the poster when controls are disabled because it's clickable
and the native poster can take over */
.vjs-controls-disabled .vjs-poster {
display: none;
}
/* Hide the poster when native controls are used otherwise it covers them */
.vjs-using-native-controls .vjs-poster {
display: none;
}

gkatsev added a commit to gkatsev/video.js that referenced this issue Jan 11, 2017
We previously hid the poster image when controls were disabled because
the poster image had a click handler on it. However, this meant that in
the case of Flash, which doesn't have a native poster image ability, we
lost the poster.

Fixes videojs#1625.
gkatsev added a commit that referenced this issue Jan 11, 2017
We previously hid the poster image when controls were disabled because
the poster image had a click handler on it. However, this meant that in
the case of Flash, which doesn't have a native poster image ability, we
lost the poster.

Fixes #1625.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants