Skip to content

Commit

Permalink
fix: turn on strict mode again (#6334)
Browse files Browse the repository at this point in the history
We had to turn off strict mode (#4551) in Video.js due to a change in vtt.js. That has now been fixed in videojs/vtt.js#40 and released as part of 0.15.2 which will be available via #6333.

Fixes videojs/vtt.js#15
  • Loading branch information
gkatsev authored Dec 2, 2019
1 parent 7bbd0ca commit ca84448
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
8 changes: 0 additions & 8 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ export default cliargs => [
format: 'umd',
file: 'dist/video.js',
name: 'videojs',
strict: false,
banner,
globals: globals.browser
},
Expand All @@ -136,13 +135,11 @@ export default cliargs => [
{
format: 'es',
file: 'dist/video.es.js',
strict: false,
banner,
globals: globals.module
}, {
format: 'cjs',
file: 'dist/video.cjs.js',
strict: false,
banner,
globals: globals.module
}
Expand All @@ -167,7 +164,6 @@ export default cliargs => [
format: 'umd',
file: 'dist/alt/video.novtt.js',
name: 'videojs',
strict: false,
banner: compiledLicense(Object.assign({includesVtt: true}, bannerData)),
globals: globals.browser
},
Expand All @@ -193,13 +189,11 @@ export default cliargs => [
{
format: 'es',
file: 'core.es.js',
strict: false,
banner,
globals: globals.module
}, {
format: 'cjs',
file: 'core.js',
strict: false,
banner,
globals: globals.module
}
Expand All @@ -220,7 +214,6 @@ export default cliargs => [
format: 'umd',
name: 'videojs',
file: 'dist/alt/video.core.js',
strict: false,
banner,
globals: globals.browser
},
Expand All @@ -242,7 +235,6 @@ export default cliargs => [
format: 'umd',
name: 'videojs',
file: 'dist/alt/video.core.novtt.js',
strict: false,
banner: compiledLicense(Object.assign({includesVtt: true}, bannerData)),
globals: globals.browser
},
Expand Down
2 changes: 1 addition & 1 deletion src/js/tech/html5.js
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,7 @@ Html5.Events = [
['featuresNativeVideoTracks', 'supportsNativeVideoTracks'],
['featuresNativeAudioTracks', 'supportsNativeAudioTracks']
].forEach(function([key, fn]) {
defineLazyProperty(Html5.prototype, key, () => Html5[fn](), false);
defineLazyProperty(Html5.prototype, key, () => Html5[fn](), true);
});

/**
Expand Down

0 comments on commit ca84448

Please sign in to comment.