Skip to content

Commit

Permalink
fix: need to determine featuresVideoFrameCallback before setting sour…
Browse files Browse the repository at this point in the history
…ce (#7812)

the tech needs to know whether or not the underlying element supports requestVideoFrameCallback before calling setSource

Fixes #7807
  • Loading branch information
joeflateau authored Jun 28, 2022
1 parent fb43a69 commit b22a08a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/js/tech/html5.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ class Html5 extends Tech {
const source = options.source;
let crossoriginTracks = false;

this.featuresVideoFrameCallback = this.featuresVideoFrameCallback && this.el_.tagName === 'VIDEO';

// Set the source if one is provided
// 1) Check if the source is new (if not, we want to keep the original so playback isn't interrupted)
// 2) Check to see if the network state of the tag was failed at init, and if so, reset the source
Expand Down Expand Up @@ -114,8 +116,6 @@ class Html5 extends Tech {
// into a `fullscreenchange` event
this.proxyWebkitFullscreen_();

this.featuresVideoFrameCallback = this.featuresVideoFrameCallback && this.el_.tagName === 'VIDEO';

this.triggerReady();
}

Expand Down
5 changes: 4 additions & 1 deletion test/unit/tech/html5.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,10 @@ QUnit.test('supports getting available media playback quality metrics', function

QUnit.test('featuresVideoFrameCallback is false for audio elements', function(assert) {
const el = document.createElement('audio');
const audioTech = new Html5({el});
const audioTech = new Html5({
el,
source: [{src: 'https://example.org/stream.m3u8'}]
});

assert.strictEqual(audioTech.featuresVideoFrameCallback, false, 'Html5 with audio element should not support rvf');

Expand Down

0 comments on commit b22a08a

Please sign in to comment.