-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable simple class extensions without any constructor.
`videojs.extends` now properly handles the case when there is no constructor provided for the child class. Fixes #2303.
- Loading branch information
1 parent
8d33388
commit a9964d0
Showing
2 changed files
with
20 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import extendsFn from '../../src/js/extends.js'; | ||
|
||
q.module('extends.js'); | ||
|
||
test('should add implicit parent constructor call', function(){ | ||
var superCalled = false; | ||
var Parent = function() { | ||
superCalled = true; | ||
}; | ||
var Child = extendsFn(Parent, { | ||
foo: 'bar' | ||
}); | ||
var child = new Child(); | ||
ok(superCalled, 'super constructor called'); | ||
ok(child.foo, 'child properties set'); | ||
}); |