Skip to content

Commit

Permalink
@gkatsev deep clone el for iOS to preserve tracks. closes #2494
Browse files Browse the repository at this point in the history
  • Loading branch information
gkatsev committed Aug 19, 2015
1 parent 3228821 commit 904bf0c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ CHANGELOG
* @gkatsev removed non-default track auto-disabling ([view](https://github.com/videojs/video.js/pull/2475))
* @gkatsev exported event helpers on videojs object ([view](https://github.com/videojs/video.js/pull/2491))
* @nickygerritsen fixed texttrack handling in IE10 ([view](https://github.com/videojs/video.js/pull/2481))
* @gkatsev deep clone el for iOS to preserve tracks ([view](https://github.com/videojs/video.js/pull/2494))

--------------------

Expand Down
17 changes: 1 addition & 16 deletions src/js/tech/html5.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class Html5 extends Tech {

// If the original tag is still there, clone and remove it.
if (el) {
const clone = el.cloneNode(false);
const clone = el.cloneNode(true);
el.parentNode.insertBefore(clone, el);
Html5.disposeMediaElement(el);
el = clone;
Expand All @@ -148,21 +148,6 @@ class Html5 extends Tech {
})
);
}

if (this.options_.tracks) {
for (let i = 0; i < this.options_.tracks.length; i++) {
const track = this.options_.tracks[i];
let trackEl = document.createElement('track');
trackEl.kind = track.kind;
trackEl.label = track.label;
trackEl.srclang = track.srclang;
trackEl.src = track.src;
if ('default' in track) {
trackEl.setAttribute('default', 'default');
}
el.appendChild(trackEl);
}
}
}

// Update specific tag settings, in case they were overridden
Expand Down

0 comments on commit 904bf0c

Please sign in to comment.