Close GH-659: Allow event handlers registered with one() to be remove…

…d with off().. Fixes #658
videojs · Jul 29, 2013 · 334ff59 · 334ff59
1 parent a809954
commit 334ff59
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/js/events.js b/src/js/events.js
@@ -329,8 +329,10 @@ vjs.trigger = function(elem, event) {
  * @return {[type]}
  */
 vjs.one = function(elem, type, fn) {
-  vjs.on(elem, type, function(){
-    vjs.off(elem, type, arguments.callee);
+  var func = function(){
+    vjs.off(elem, type, func);
     fn.apply(this, arguments);
-  });
+  };
+  func.guid = fn.guid = fn.guid || vjs.guid++;
+  vjs.on(elem, type, func);
 };