Allow add/remove listeners in callbacks (#119) #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a callback to mutate the listeners (e.g. removing yourself), previously changed the iterated array, causing bugs. Remove the problem by always copying the array, so on()/off() become safe to call at any time.
odinho
force-pushed
the
mutation_safe_listeners
branch
from
84bfab7 to
53d5a4f
Compare
|
Also added a test, because why not. |
|
Awesome. LGTM |
|
LGTM |
|
Thanks for the contribution, @odinho! |
2 tasks
aN0obIs
pushed a commit
to aN0obIs/mux.js
that referenced
this pull request
Apr 28, 2017
Using a callback to mutate the listeners (e.g. removing yourself), previously changed the iterated array, causing bugs. Remove the problem by always copying the array, so on()/off() become safe to call at any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a callback to mutate the listeners (e.g. removing yourself), previously
changed the iterated array, causing bugs. Remove the problem by always copying
the array, so on()/off() become safe to call at any time.