Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove extra abort call #1528

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: remove extra abort call #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/segment-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ export const fixBadTimelineChange = (segmentLoader) => {
return;
}
segmentLoader.pause();
segmentLoader.abort_();
segmentLoader.resetEverything();
segmentLoader.load();
};
Expand Down
5 changes: 0 additions & 5 deletions test/segment-loader.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,14 +521,10 @@ QUnit.test('fixBadTimelineChange calls pause, resetEverything and load on a segm
let pauseCalls = 0;
let resetEverythingCalls = 0;
let loadCalls = 0;
let abortCalls = 0;
let mockSegmentLoader = {
pause() {
pauseCalls++;
},
abort_() {
abortCalls++;
},
resetEverything() {
resetEverythingCalls++;
},
Expand All @@ -548,7 +544,6 @@ QUnit.test('fixBadTimelineChange calls pause, resetEverything and load on a segm
assert.equal(pauseCalls, 1, 'calls pause once');
assert.equal(resetEverythingCalls, 1, 'calls resetEverything once');
assert.equal(loadCalls, 1, 'calls load once');
assert.equal(abortCalls, 1, 'calls abort once');
});

QUnit.module('safeBackBufferTrimTime');
Expand Down
Loading