Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: videoTimestampOffset in sourceUpdater #1519

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

adrums86
Copy link
Contributor

Description

fix videoTimestampOffset comparison

Specific Changes proposed

add _ to this.videoTimestampOffset so we compare the value instead of the function. 😁

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (0a7a362) to head (b3998f0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1519   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files          43       43           
  Lines       11097    11097           
  Branches     2532     2532           
=======================================
  Hits         9578     9578           
  Misses       1519     1519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@adrums86 adrums86 merged commit d6851cc into main Jun 14, 2024
13 of 14 checks passed
@adrums86 adrums86 deleted the fix-videoTimestampOffset branch June 14, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants