Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use paren media sequence sync for audio and vtt, since they are opt-in features and can be enabled after main init. #1505

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

dzianis-dashkevich
Copy link
Contributor

@dzianis-dashkevich dzianis-dashkevich commented Apr 22, 2024

Description

audio and vtt segment loaders are opt-in features and can be enabled after the main start. (eg: via UI)
We should align the media sequence start time with the main for them.

Specific Changes proposed

Use parent for vtt and audio media sequence storages.
parent should be main.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

…opt-in features and can be enabled after main init
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (be289f6) to head (89a8b9d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
+ Coverage   86.27%   86.29%   +0.01%     
==========================================
  Files          43       43              
  Lines       10886    10901      +15     
  Branches     2506     2508       +2     
==========================================
+ Hits         9392     9407      +15     
  Misses       1494     1494              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. LGTM!

@dzianis-dashkevich dzianis-dashkevich merged commit bdfe0e0 into main Apr 22, 2024
12 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the fix-live-vtt-issues branch April 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants