Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: account for difference between duration info in the playlist and the actual duration #1470

Merged
merged 2 commits into from
Dec 27, 2023
Merged

fix: account for difference between duration info in the playlist and the actual duration #1470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af8c98c
fix: account difference between duration info in the playlist and the…
Dec 26, 2023
72e5c05
fix: account for zero length segments
Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/playlist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,20 @@ export const getMediaInfoForTime = function({

time -= partAndSegment.duration;

if (time === 0) {
// we are exactly at the end of the current segment
const canUseFudgeFactor = partAndSegment.duration > TIME_FUDGE_FACTOR;
const isExactlyAtTheEnd = time === 0;
const isExtremelyCloseToTheEnd = canUseFudgeFactor && (time + TIME_FUDGE_FACTOR >= 0);

if (isExactlyAtTheEnd || isExtremelyCloseToTheEnd) {
// 1) We are exactly at the end of the current segment.
// 2) We are extremely close to the end of the current segment (The difference is less than 1 / 30).
// We may encounter this situation when
// we don't have exact match between segment duration info in the manifest and the actual duration of the segment
// For example:
// We appended 3 segments 10 seconds each, meaning we should have 30 sec buffered,
// but we the actual buffered is 29.99999
//
// In both cases:
// if we passed current time -> it means that we already played current segment
// if we passed buffered.end -> it means that this segment is already loaded and buffered

Expand Down