Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow audio fmp4 emsg probe #1385

Merged
merged 4 commits into from
Apr 1, 2023
Merged

fix: allow audio fmp4 emsg probe #1385

merged 4 commits into from
Apr 1, 2023

Conversation

adrums86
Copy link
Contributor

Description

Fixes #1379

Specific Changes proposed

Change the order of nested callbacks to the transmuxer to allow for fmp4 audio EMSG id3 metadata probing.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1385 (a1cef32) into main (9520070) will not change coverage.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files          40       40           
  Lines        9953     9953           
  Branches     2307     2307           
=======================================
  Hits         8497     8497           
  Misses       1456     1456           
Impacted Files Coverage Δ
src/media-segment-request.js 95.50% <90.90%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrums86 adrums86 self-assigned this Mar 31, 2023
Copy link
Contributor

@wseymour15 wseymour15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrums86 adrums86 merged commit c90863c into main Apr 1, 2023
@adrums86 adrums86 deleted the fix-emsg-audio branch April 1, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does emsg ID3 metadata only work if it's on a video track?
2 participants