refactor: remove nested loop from removeDuplicateCuesFromTrack function #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1381 +/- ##
==========================================
- Coverage 85.36% 85.35% -0.01%
==========================================
Files 40 40
Lines 9957 9951 -6
Branches 2311 2306 -5
==========================================
- Hits 8500 8494 -6
Misses 1457 1457
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-barstow
commented
Mar 17, 2023
|
|
||
| if (duplicates.length) { | ||
| duplicates.forEach(dupe => track.removeCue(dupe)); | ||
| for (let i = cues.length - 1; i >= 0; i--) { |
There was a problem hiding this comment.
track.removeCue() modifies the track.cues array as we iterate through it, so this iterates backwards to avoid problems from reindexing.
dzianis-dashkevich
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
removeDuplicateCuesFromTrack()function was poorly optimized. The nested loop would run a staggering number of times in cases of very large VTT files. This change accomplishes duplicate cue removal with a single loop.