feat: add compatibility layer for video.js 7 and 8 #1322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There will be a few functions in Video.js deprecated in 8.0 including
videojs.mergeOptions
andvideojs.createTimeRanges
. Both functions still work, but will log a deprecation warning. We do not want to log deprecation warnings out of the box, so with this PR we call the new methods via a small utility module,vjs-compat
.Tested with both Video.js 7.x and Video.js
next
branch.Specific Changes proposed
util/vjs-compat
with two functions:merge
, which delegates tovideojs.obj.merge
, falling back tovideojs.mergeOptions
createTimeRanges
, which delegates tovideojs.time.createTimeRanges
, falling back tovideojs.createTimeRanges
videojs.plugin()
videojs-contrib-eme
, so that it will not log deprecation warnings in tests.Requirements Checklist