Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify hls option deprecation warning #1257

Merged
merged 2 commits into from
Mar 2, 2022
Merged

fix: clarify hls option deprecation warning #1257

merged 2 commits into from
Mar 2, 2022

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Mar 2, 2022

Fixes #1256

misteroneill
misteroneill previously approved these changes Mar 2, 2022
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gkatsev gkatsev changed the title fix: make deprecation warning for hls option more clear fix: clarify hls option deprecation warning Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1257 (7eb3eb8) into main (0964cb4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files          39       39           
  Lines        9807     9807           
  Branches     2279     2279           
=======================================
  Hits         8465     8465           
  Misses       1342     1342           
Impacted Files Coverage Δ
src/videojs-http-streaming.js 91.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0964cb4...7eb3eb8. Read the comment docs.

@gkatsev gkatsev merged commit 211cbe8 into main Mar 2, 2022
@gkatsev gkatsev deleted the gkatsev-patch-1 branch March 2, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving the wording of a warning. - VIDEOJS: WARN: Using hls options is deprecated. Use vhs instead.
2 participants