Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix seekable not updating after the first change for live streams #1233

Merged

Conversation

gesinger
Copy link
Contributor

@gesinger gesinger commented Dec 9, 2021

This removes a check for hasCreatedSourceBuffers that short circuited
onSyncInfoUpdate_. It also adds a comment about how to add the check
in the future, as a simple change of truthiness leads to other issues
in playing back a live stream.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

This removes a check for hasCreatedSourceBuffers that short circuited
onSyncInfoUpdate_. It also adds a comment about how to add the check
in the future, as a simple change of truthiness leads to other issues
in playing back a live stream.
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #1233 (20d6a25) into main (bfd0ad0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   86.31%   86.30%   -0.02%     
==========================================
  Files          39       39              
  Lines        9796     9796              
  Branches     2278     2278              
==========================================
- Hits         8455     8454       -1     
- Misses       1341     1342       +1     
Impacted Files Coverage Δ
src/master-playlist-controller.js 94.65% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd0ad0...20d6a25. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants