Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run networkInfo tests against ie11 #1221

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

evanfarina
Copy link
Contributor

Description

The stubbing of networkInfo doesn't play nicely with ie11 which complains with the following message: Assignment to read-only properties is not allowed in strict mode. After speaking with Gary, we've decided to skip these tests in IE.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #1221 (ce602f1) into main (061cf3c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1221   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files          39       39           
  Lines        9752     9752           
  Branches     2267     2267           
=======================================
  Hits         8429     8429           
  Misses       1323     1323           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061cf3c...ce602f1. Read the comment docs.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally that these tests are now skipped on IE.

@gkatsev gkatsev merged commit aaedde3 into videojs:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants