-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/llhls query #1199
Fix/llhls query #1199
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
+ Coverage 86.59% 86.61% +0.01%
==========================================
Files 39 39
Lines 9645 9651 +6
Branches 2233 2235 +2
==========================================
+ Hits 8352 8359 +7
+ Misses 1293 1292 -1
Continue to review full report at Codecov.
|
test/loader-common.js
Outdated
loader.on('trackinfo', () => { | ||
loader.on('playlistupdate', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the race condition that currently causes ie 11 to fail
|
||
uri += `${symbol}${str}`; | ||
}); | ||
['_HLS_skip', '_HLS_msn', '_HLS_part'].forEach(function(name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make sure that we keep the parameters in an expected order of skip
, msn
, and part
as it makes reading the urls much easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested it and it works.
Description
Fixes #1198