Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a github-release github action #1182

Merged
merged 10 commits into from
Aug 17, 2021
Merged

Conversation

brandonocasey
Copy link
Contributor

Description

Automates the github release changelog process.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #1182 (9f63618) into main (ff34277) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files          39       39           
  Lines        9602     9602           
  Branches     2219     2219           
=======================================
  Hits         8307     8307           
  Misses       1295     1295           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff34277...9f63618. Read the comment docs.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

with:
body_path: RELEASE-CHANGELOG.md
token: ${{github.token}}
files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want to list the dist files here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd need to run the build step first, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that sounds good, I can write a way to upload all the files in that directory too.

uses: softprops/action-gh-release@v1
with:
body_path: RELEASE-CHANGELOG.md
token: ${{github.token}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this is the default, is it worth noting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, from my testing on a separate repo, not sure if we need new permissions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github adds a token by default for the current repo as well, so, it should be fine. A separate one is only needed if you need special permissions or something.

.github/workflows/github-release.yml Show resolved Hide resolved
.github/workflows/github-release.yml Outdated Show resolved Hide resolved
.github/workflows/github-release.yml Show resolved Hide resolved
.github/workflows/github-release.yml Show resolved Hide resolved
gkatsev
gkatsev previously approved these changes Aug 12, 2021
gkatsev
gkatsev previously approved these changes Aug 12, 2021
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

gkatsev
gkatsev previously approved these changes Aug 17, 2021
@brandonocasey brandonocasey merged commit e8230a9 into main Aug 17, 2021
@brandonocasey brandonocasey deleted the chore/github-release branch August 17, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants