-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a github-release github action #1182
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1182 +/- ##
=======================================
Coverage 86.51% 86.51%
=======================================
Files 39 39
Lines 9602 9602
Branches 2219 2219
=======================================
Hits 8307 8307
Misses 1295 1295 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/github-release.yml
Outdated
with: | ||
body_path: RELEASE-CHANGELOG.md | ||
token: ${{github.token}} | ||
files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want to list the dist files here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we'd need to run the build step first, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that sounds good, I can write a way to upload all the files in that directory too.
uses: softprops/action-gh-release@v1 | ||
with: | ||
body_path: RELEASE-CHANGELOG.md | ||
token: ${{github.token}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this is the default, is it worth noting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work, from my testing on a separate repo, not sure if we need new permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github adds a token by default for the current repo as well, so, it should be fine. A separate one is only needed if you need special permissions or something.
Co-authored-by: Gary Katsevman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Description
Automates the github release changelog process.