Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not add placeholder properties for AUDIO groups without a uri #1167

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

brandonocasey
Copy link
Contributor

Fixes Song - ts Audio only which doesn't work because it has invalid media groups (without uris)

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #1167 (cb6945c) into main (bcc2949) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
+ Coverage   86.45%   86.47%   +0.02%     
==========================================
  Files          39       39              
  Lines        9562     9577      +15     
  Branches     2204     2210       +6     
==========================================
+ Hits         8267     8282      +15     
  Misses       1295     1295              
Impacted Files Coverage Δ
src/manifest.js 93.45% <100.00%> (+0.38%) ⬆️
src/master-playlist-controller.js 94.59% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc2949...cb6945c. Read the comment docs.

@brandonocasey brandonocasey changed the title fix: do not add placeholder for AUDIO groups without a uri fix: do not add placeholder properties for AUDIO groups without a uri Jul 15, 2021
@brandonocasey brandonocasey force-pushed the fix/no-placeholder-for-main-playlists branch from 53c11eb to f84ea09 Compare July 15, 2021 19:26
gkatsev
gkatsev previously approved these changes Jul 19, 2021
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fixed

src/manifest.js Outdated Show resolved Hide resolved
Co-authored-by: Garrett Singer <[email protected]>
@brandonocasey brandonocasey merged commit 8c10733 into main Jul 19, 2021
@brandonocasey brandonocasey deleted the fix/no-placeholder-for-main-playlists branch July 19, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants