Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default maxPlaylistRetries to Infinity #1142

Merged

Conversation

evanfarina
Copy link
Contributor

Description

Set a default for the option MaxPlaylistRetries (default should have been Infinity, seems like there was a bad merge)

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #1142 (99dd2d9) into main (0f35f7e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1142   +/-   ##
=======================================
  Coverage   86.45%   86.46%           
=======================================
  Files          39       39           
  Lines        9489     9492    +3     
  Branches     2189     2190    +1     
=======================================
+ Hits         8204     8207    +3     
  Misses       1285     1285           
Impacted Files Coverage Δ
src/master-playlist-controller.js 94.51% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f35f7e...99dd2d9. Read the comment docs.

@gkatsev gkatsev merged commit 4428e3a into videojs:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants