Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fullscreen-api): update ios media API polyfill to fix fullscreen … #701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OleksaDid
Copy link

@OleksaDid OleksaDid commented Feb 27, 2018

…bugs on mobile

updated ios media API polyfills to avoid non-standart methods that are not recommended to use

Description

Please explain the changes you made here. Commit your changes with npm run commit instead of git commit.

Specify if it's a fix, feature or breaking change to update the version on NPM.

Thank you!

Checklist

Please, check that you have been followed next steps:

  • I've read the (contributing)[https://github.com/videogular/videogular2/blob/master/CONTRIBUTING.md] guidelines
  • Code compiles correctly (run npm start)
  • Created tests (if necessary)
  • All tests passing (run npm test)
  • Extended the README / documentation (if necessary)

…bugs on mobile

updated ios media API polyfills to avoid non-standart methods that are not recommended to use (

(cherry picked from commit 54a24f1)
@Elecash
Copy link
Member

Elecash commented Jun 16, 2018

@alexdid I've tested on latests versions of iOS (11.3.1 and 11.4) and everything worked as expected.

Do you have more info about why we should change to webkitRequestFullscreen and webkitCancelFullScreen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants