Skip to content

1 16 19 Meeting Minutes

Jump to bottom
John Bartos edited this page Jan 16, 2019 · 2 revisions

Hls.js Call Minutes - January 16, 2019

Attendees

  • John Bartos
  • Michael Cunningham
  • Jamie Stackhouse
  • Fred Bochmann
  • Dan Sparacio
  • Dailos Merida
  • Jonathon Fairfull
  • FastEddy

Agenda

  • Typescript
  • Contributor guidelines
  • Michael's upcoming Hls.js contributions
  • IE11 incompatibilities
  • Possible feature requests

Minutes

  • Introductions, etc. - two new contributors joining
  • Recapping 0.12.0 release
  • John: contributor guidelines are i
  • Jamie: build & test process made TS-ing the codebase difficult
    • Leaked into the buffer-controller PR - tried to split out the process improvements from the actual PR
    • Mixing of types in the Hls.js codebase makes TSing difficult too
    • Takeaway: don't worry about making the cleanest TS code, focus on getting types in first & then iterate
    • Leave the events to the end
    • Jamie will own typescripting the codebase
    • John: not opposed to changing the event structure to have a more explicit dependency tree
      • What else might change for a major
    • TS in Babel - can we merge this?
      • The goal is to have webpack do module concatenation so that the codebase is smaller
    • Jamie: TS should not meaningfully increase the size of the codebase
  • Michael: have been most active triaging and reviewing PRs; keeping things moving with actionable feedback (very much appreciated!)
  • Added Ace editor to the Hls.js demo page so that we can modify any Hls.js config option in the demo
    • Working on adding persistence
  • Have a few bugfixes from a downstream project which I'll soon upstream
  • We're using unpolyfilled array methods which in IE11
    • High priority
  • John/Rob: Where possible, we should be transpiling our polyfills into the codebase instead of adding them to globals at runtime
  • Michael: I'll make an issue and we can discuss solutions there
  • Rob: Can we configure babel to polyfill at compile time whatever methods we define?
  • John: Can we have some linting step which detects incompatible methods
  • Michael: Can we have a required build for IE?
    • John: good idea
  • Fred: Is it possible to support two subtitle tracks at the same time?
    • Rob: I think we may be able to activate both tracks at the same time, but the layout may overlap. You'd probably run into issues
    • In Hls.js we probably only load 1 track at a time
    • Fred: If the browser supports another track we can probably make both show with CSS
  • Fred: Display two renditions at the same time (e.g. for multiple camera angles)
    • Rob: two Hls.js instances with media controller API
    • Jamie: Media controller is deprecated
    • John: It would require a lot of work to be able to play two renditions in one instance
  • Discussion about various stream syncing mechanisms
  • Rob: More feature detection
  • John: DangerJS to enforce guidelines
  • Jamie: How do we leverage functional tests in a better way
  • Fred: Developers making code changes don't always know the properties of our test streams
    • Rob: Guidelines should include a "getting started" guide which has a focus on our test assets
  • Rob: Better organization of test assets

Contributing Guideline Rough Draft

Pull Requests

  • Ensure that all demo page assets work across browsers
    • The developer should be expected to test their changes against our demo assets
  • Pull requests should be minimal in scope and changes, and be focused on a single problem
  • Pull requests must have unit tests which cover the changes as completely as possible
  • Pull request templates must be filled out

Getting Started guide

  • How to build & test
  • What our test assets represent
Clone this wiki locally